Skip to content

fix(#6551): Unexpected behaviour if caddyhttp.Route is provisioned twice #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(#6551): Unexpected behaviour if caddyhttp.Route is provisioned twice #6558

merged 1 commit into from
Sep 3, 2024

Conversation

jbro
Copy link
Contributor

@jbro jbro commented Sep 2, 2024

ref: #6551

@jbro jbro mentioned this pull request Sep 2, 2024
Closed
mholt
mholt approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@mholt mholt merged commit 91e62db into caddyserver:master Sep 3, 2024
30 of 33 checks passed
@mholt mholt added this to the v2.8.5 milestone Sep 3, 2024
@jbro jbro deleted the bug-route-provision branch September 3, 2024 18:31
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbro @mholt