Skip to content

fileserver: add sort options #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2024
Merged

fileserver: add sort options #6468

merged 6 commits into from
Aug 5, 2024

Conversation

lollipopkit
Copy link
Contributor

I have tested the config:

:8082 {
	root * .
	file_server browse {
		sort size desc
	}
}
Screenshot 2024-07-22 at 20 32 31

Additionally, a .caddyfiletest file were wrote, but I don't know how to run it.

The related doc PR can be found here.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lollipopkit lollipopkit mentioned this pull request Jul 22, 2024
Merged
mohammed90
mohammed90 reviewed Jul 22, 2024
View reviewed changes
caddytest/integration/caddyfile_adapt/file_server_sort.caddyfiletest Outdated
Comment on lines 24 to 31
"file_server": {
"size": {},
"desc": {}
},
"file_server_order": [
"size",
"desc"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new field is sort, so these lines cannot be right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...my fault

@lollipopkit lollipopkit requested a review from mohammed90 August 5, 2024 10:51
mholt
mholt requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this enhancement. I just want to make sure that the rather freeform input is strictly validated to prevent surprises.

@lollipopkit lollipopkit requested a review from mholt August 5, 2024 13:40
mholt
mholt requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, getting closer!!

mholt
mholt approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

I think we can give this a shot. Please help maintain this feature if any bugs are reported 😊

@lollipopkit
Copy link
Contributor Author

Of course. Thanks again :)

@mholt mholt merged commit b198678 into caddyserver:master Aug 5, 2024
23 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
@francislavoie francislavoie mentioned this pull request Jul 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

@mohammed90 mohammed90 Awaiting requested review from mohammed90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lollipopkit @CLAassistant @mholt @mohammed90