Skip to content

Conversation

matthewpi
Copy link
Member

Adds the ability to use trace_id as a placeholder so it can be used wherever it is needed. Such as being returned in a header to the client.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the tracing code but I think this looks reasonable. Thanks!

@francislavoie francislavoie changed the title modules(tracing): add http.vars.trace_id placeholder tracing: add http.vars.trace_id placeholder May 8, 2024
@francislavoie francislavoie added the feature ⚙️ New feature or request label May 8, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone May 8, 2024
@mholt mholt merged commit 0b5720f into caddyserver:master May 8, 2024
@matthewpi matthewpi deleted the trace-id-placeholder branch May 8, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants