httpcaddyfile: Fix expression matcher shortcut in snippets #6288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
commented
May 1, 2024
Comment on lines
+1285
to
+1288
| } | ||
|
|
||
| // convenient way to specify a single path match | ||
| if strings.HasPrefix(tkn.Text, "/") { |
There was a problem hiding this comment.
I just don't like else if when all branches return. It can be simplified to simple if and the comment can be hoisted up above the if.
mohammed90
approved these changes
May 1, 2024
francislavoie
commented
May 1, 2024
| @@ -356,6 +358,19 @@ func (t Token) NumLineBreaks() int { | |||
| return lineBreaks | |||
| } | |||
|
|
|||
| // Clone returns a deep copy of the token. | |||
| func (t Token) Clone() Token { | |||
There was a problem hiding this comment.
I needed to make a Clone() because the token has some unexported fields that can't be copied from inside the httpcaddyfile package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6287