logging: Fix default access logger #6251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
732653f to
a1a5ec6
Compare
a5d6f21 to
ae03e14
Compare
|
I made an additional change to simplify the logic for reading the logger names config, removes the "retry without port" because really there should never be any config with a port, it makes it ambiguous. I've also added a check in the HTTP app's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6248
The problem is that we were skipping hosts that have
""as their logger name (which happens when using thelogdirective with no options).This is a regression from #6088, but the reporter in #6248 had a different problem on 2.7.6 which I think we've since fixed (causing
skip_hoststo not work).Also, I added a
SplitHostPortin a couple spots cause I realized during testing that we were using the host with the port when we shouldn't to look up the logger names. This more thoroughly completes the idea from #5881