caddyfile: Assert having a space after heredoc marker to simply check #6117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't reproduce the original Timeout using the minimized testcase, so it was an attempt at optimization. |
I have tested the new testcase clusterfuzz-testcase-fuzz-format-5806400649363456.txt, see #6099 (comment) Before $ time ./caddy fmt clusterfuzz-testcase-fuzz-format-5806400649363456.txt > /dev/null
________________________________________________________
Executed in 7.34 secs fish external
usr time 7.30 secs 612.00 micros 7.30 secs
sys time 0.03 secs 931.00 micros 0.03 secsAfter $ time ./caddy fmt clusterfuzz-testcase-fuzz-format-5806400649363456.txt > /dev/null
________________________________________________________
Executed in 62.86 millis fish external
usr time 59.54 millis 72.00 micros 59.47 millis
sys time 21.77 millis 972.00 micros 20.80 millisI think this PR already has enough speed without hitting the timeout. |
|
Wow 🤯 big difference. Thanks! |
francislavoie
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6099
We assert that heredocClosingMarker is followed by a unicode.Space to simplify the check of heredoc closing
That's about a 10x speed increase in clusterfuzz-testcase-minimized-fuzz-format-5806400649363456.txt.
Before
After