with per_host in metrics, how about compatible with old version #6604
Description
current caddyfile is using:
{
servers {
metrics
}
}
if i switch to caddy@master (with per_host support in metrics), then above config will cause panic!! because missing :port (ie servers :80, servers :443 )
the full log:
panic: duplicate metrics collector registration attempted
goroutine 1 [running]:
github.com/prometheus/client_golang/prometheus.(*Registry).MustRegister(0xc00068ddb0, {0xc000812f20?, 0x1d1de87?, 0x4?})
github.com/prometheus/client_golang@v1.19.1/prometheus/registry.go:405 +0x66
github.com/prometheus/client_golang/prometheus/promauto.Factory.NewGaugeVec({{0x22edd30?, 0xc00068ddb0?}}, {{0x1d1fa3f, 0x5}, {0x1d1de87, 0x4}, {0x1d51a67, 0x12}, {0x1da476e, 0x34}, ...}, ...)
github.com/prometheus/client_golang@v1.19.1/prometheus/promauto/auto.go:308 +0x163
github.com/caddyserver/caddy/v2/modules/caddyhttp.initHTTPMetrics({{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, 0x0}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/metrics.go:46 +0x130
github.com/caddyserver/caddy/v2/modules/caddyhttp.newMetricsInstrumentedHandler.func1()
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/metrics.go:121 +0x38
sync.(*Once).doSlow(0x1?, 0x3?)
sync/once.go:76 +0xb4
sync.(*Once).Do(...)
sync/once.go:67
github.com/caddyserver/caddy/v2/modules/caddyhttp.newMetricsInstrumentedHandler({{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, 0x0}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/metrics.go:120 +0xb3
github.com/caddyserver/caddy/v2/modules/caddyhttp.wrapMiddleware({{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, 0x0}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/routes.go:321 +0x99
github.com/caddyserver/caddy/v2/modules/caddyhttp.(*Route).ProvisionHandlers(0xc000978a88, {{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, ...}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/routes.go:167 +0x2e5
github.com/caddyserver/caddy/v2/modules/caddyhttp.RouteList.ProvisionHandlers({0xc000978a88, 0xb, 0xc000975190?}, {{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/routes.go:212 +0xa9
github.com/caddyserver/caddy/v2/modules/caddyhttp.(*App).Provision(0xc0006f3680, {{0x22f2478, 0xc00080ee70}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, ...}, ...})
github.com/caddyserver/caddy/v2@v2.8.4/modules/caddyhttp/app.go:354 +0xe1e
github.com/caddyserver/caddy/v2.Context.LoadModuleByID({{0x22f24b0, 0xc00068de00}, 0xc0004ae360, 0xc0000bed20, {0xc000645150, 0x1, 0x1}, {0x0, 0x0, 0x0}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/context.go:389 +0x695
github.com/caddyserver/caddy/v2.Context.App({{0x22f24b0, 0xc00068de00}, 0xc0004ae360, 0xc0000bed20, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}, ...}, ...)
github.com/caddyserver/caddy/v2@v2.8.4/context.go:465 +0xee
github.com/caddyserver/caddy/v2.provisionContext.func3(...)
github.com/caddyserver/caddy/v2@v2.8.4/caddy.go:545
github.com/caddyserver/caddy/v2.provisionContext(0x1?, 0x0)
github.com/caddyserver/caddy/v2@v2.8.4/caddy.go:550 +0x53c
github.com/caddyserver/caddy/v2.run(0x1942f40?, 0x0)
github.com/caddyserver/caddy/v2@v2.8.4/caddy.go:400 +0x78
github.com/caddyserver/caddy/v2.Validate(0xc0000bed20)
github.com/caddyserver/caddy/v2@v2.8.4/caddy.go:714 +0x5a
github.com/caddyserver/caddy/v2/cmd.cmdValidateConfig({0x0?})
github.com/caddyserver/caddy/v2@v2.8.4/cmd/commandfuncs.go:551 +0x155
github.com/caddyserver/caddy/v2/cmd.init.1.func8.WrapCommandFuncForCobra.1(0xc000924908, {0x1d1de5b?, 0x4?, 0x1d1ddc7?})
github.com/caddyserver/caddy/v2@v2.8.4/cmd/cobra.go:141 +0x2f
github.com/spf13/cobra.(*Command).execute(0xc000924908, {0xc0006a3660, 0x2, 0x2})
github.com/spf13/cobra@v1.8.1/command.go:985 +0xaaa
github.com/spf13/cobra.(*Command).ExecuteC(0xc00098a608)
github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/caddyserver/caddy/v2/cmd.Main()
github.com/caddyserver/caddy/v2@v2.8.4/cmd/main.go:75 +0x1dd
main.main()
caddy/main.go:26 +0xf