Skip to content

Question on sync.Pool for eTag and etag Hash function #6205

@jadidbourbaki

Description

@jadidbourbaki

I noticed this comment originally added by this PR (f259ed5).

Just to confirm, is the ask here to make the etag hasher be allocated through a sync.Pool? Is this an operation accessed through various go routines concurrently? Would love to try my hand at prototyping this just want to make sure I understand the ask.

Further, any interest on changing this hash function for eTags from fnv to the faster xxhash similar to the change for load balancing in reverse proxy? I imagine the need for a faster hash is not that big in this case as reloading configurations is an off the critical path operation?

Thank you for your time, and I look forward to your input.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions