Skip to content

Support setting initial version when --pattern is supplied #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support setting initial version when --pattern is supplied #57

wants to merge 2 commits into from

Conversation

jsok
Copy link
Contributor

@jsok jsok commented Jan 14, 2022

Fixes #56

jsok added 2 commits January 14, 2022 11:59
@jsok
fix: return explicit error if no tags are found
0200aeb 
`DescribeTag` has inconsistent behaviour if a pattern is supplied.
If no pattern is supplied, not finding any tags is not an error, whereas
if a pattern is supplied, it is an error to not find any tags.

Remove the ambiguity by returning an explicit error describing what
occurred and let `main` decide how to handle it.
@jsok
feat: add -initial flag
aed519c 
Surface the initial version as a flag, making it customizable too.
@gotson gotson mentioned this pull request Apr 11, 2022
Closed
@jsok jsok mentioned this pull request Apr 13, 2022
Merged
@jsok
Copy link
Contributor Author

jsok commented Jul 12, 2022

Feel free to re-open if you think #56 is worth solving.

@jsok jsok closed this Jul 12, 2022
@harnash harnash mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial version does not work if pattern is supplied
1 participant
@jsok