[3.0.x] Revert changes in tests breaking python 2.7 #6103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to commit 4e9f730
da-woods
reviewed
Mar 22, 2024
| @@ -51,46 +51,50 @@ def func_pure_implicit() -> cython.int: | |||
| def func_pure_noexcept() -> cython.int: | |||
| raise RuntimeError | |||
|
|
|||
| def print_stderr(func): | |||
| def return_stderr(func): | |||
There was a problem hiding this comment.
Suggested change
| def return_stderr(func): | |
| def print_stderr(func): |
| func() | ||
| finally: | ||
| sys.stderr = old_stderr | ||
| return stderr.getvalue().strip() |
There was a problem hiding this comment.
Suggested change
| return stderr.getvalue().strip() | |
| return print(stderr.getvalue()) |
I was wondering about doing this, which I think would let us leave everything else unchanged.
|
I'll make an alternative PR will my suggestion for simplicity. |
Feel free to close this PR if you prefer yours. |
|
I've done #6105 which I think is a smaller change, so I'll merge that assuming it works. I've checked it locally though and it seems fine. Thanks for looking into this quickly. |
|
Thank you @da-woods ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to commit 4e9f730