Skip to content

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Jul 23, 2022

Backport of #2946 and #3905 to 0.29.x

Ref: #2918

@mkoeppe mkoeppe changed the base branch from master to 0.29.x July 23, 2022 19:03
@mkoeppe mkoeppe changed the title Add PEP420 namespace support Backport to 0.29.x: Add PEP420 namespace support Jul 23, 2022
@scoder
Copy link
Contributor

scoder commented Jul 24, 2022

Thanks, but I think this bears potential for breaking some people's build. I'd like to avoid behavioural changes in 0.29.x as much as possible. It's really a legacy stable release branch.

@mkoeppe
Copy link
Author

mkoeppe commented Jul 24, 2022

I think this bears potential for breaking some people's build

Well, I just looked again at #2946 to see if there are any mentions of problems in downstream projects. I only found #3905, which I've now cherry-picked onto the branch.

@scoder
Copy link
Contributor

scoder commented Jul 31, 2022

Sorry. No new features in 0.29.x.

@scoder scoder closed this Jul 31, 2022
@mkoeppe
Copy link
Author

mkoeppe commented Jul 31, 2022

Each of 0.29.27, 0.29.29, 0.29.31 introduced new features according to https://cython.readthedocs.io/en/latest/src/changes.html

@scoder
Copy link
Contributor

scoder commented Jul 31, 2022

Each of 0.29.27, 0.29.29, 0.29.31 introduced new features

The changes in 27 and 32 have zero impact on existing code and both help integrating with external build systems. The change in 29 fixes warnings and was long tested in the master branch.

Your proposed change fixes no existing bugs, has no advantages for existing code, but risks breaking it, and has long been available as a feature in several 3.0 releases. I consider this enough reasons to reject it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants