-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
Milestone
Description
Describe the bug
SciPy main
cannot build with Cython 3.0.3
and I bisected on Cython commits:
401e880a336576b765e5d6bb1a9718947243d92b is the first bad commit
commit 401e880a336576b765e5d6bb1a9718947243d92b
Author: da-woods <dw-git@d-woods.co.uk>
Date: Fri Sep 29 11:11:22 2023 +0100
Show performance hints for nogil functions requiring exception checks (GH-5673)
Performance hints come out similar to warnings but do not make `-Werror` fail.
Cython/Compiler/Errors.py | 14 +++++++++
Cython/Compiler/ExprNodes.py | 7 +++--
Cython/Compiler/Nodes.py | 3 +-
Cython/Compiler/Options.py | 4 +++
Cython/Compiler/PyrexTypes.py | 13 ++++++++-
Cython/Compiler/Scanning.py | 1 +
Cython/Compiler/Symtab.py | 12 ++++++++
Cython/Compiler/TreeFragment.py | 8 +++++-
Cython/Compiler/UtilityCode.py | 3 +-
runtests.py | 64 +++++++++++++++++++++++++----------------
tests/run/nogil.pxd | 1 +
tests/run/nogil.pyx | 39 ++++++++++++++++++++++++-
tests/run/nogil_other.pxd | 2 ++
13 files changed, 138 insertions(+), 33 deletions(-)
create mode 100644 tests/run/nogil.pxd
create mode 100644 tests/run/nogil_other.pxd
This appears to be slightly different than gh-5747 from pandas
, though perhaps some similarity.
Code to reproduce the behaviour:
No response
Expected behaviour
No response
OS
No response
Python version
No response
Cython version
No response
Additional context
No response