[BUG] PyPy-specific compiler crash in a function with fused types #5588
Description
Describe the bug
When compiling a Cython class cpdef method with fused type arguments and default arguments, I get a compiler crash (see next section). This happens only when running Cython with pypy (PyPy 7.3), the same code compiles fine with CPython (Python 3.10). The error seems to originate from Cython.COmpiler.PyrexTypes, as shown in the traceback.
Code to reproduce the behaviour:
I have a hard time reproducing it because this comes from a larger codebase (althonos/pyhmmer) but I have the following method inside a cdef class:
cpdef TopHits search_msa(self, DigitalMSA query, SearchTargets sequences, Builder builder = None)where TopHits, DigitalMSA and Builder are Cython classes, and SearchTargets a fused type.
I'm getting the following crash, but only when compiling with PyPy, with CPython it compiles fines:
pyhmmer/plan7.pyx:5589:10: Compiler crash in AnalyseDeclarationsTransform
ModuleNode.body = StatListNode(plan7.pyx:15:0)
StatListNode.stats[116] = StatListNode(plan7.pyx:4763:5)
StatListNode.stats[0] = CClassDefNode(plan7.pyx:4763:5,
as_name = 'Pipeline',
class_name = 'Pipeline',
doc = '...',
module_name = '',
punycode_class_name = 'Pipeline',
visibility = 'private')
CClassDefNode.body = StatListNode(plan7.pyx:4764:4)
StatListNode.stats[29] = CFuncDefNode(plan7.pyx:5589:10,
args = [...]/4,
doc = '...',
has_fused_arguments = True,
is_c_class_method = 1,
modifiers = [...]/0,
outer_attrs = [...]/2,
overridable = 1,
visibility = 'private')
File 'FusedNode.py', line 62, in __init__: FusedCFuncDefNode(plan7.pyx:5589:10,
fused_compound_types = [...]/1,
match = "dest_sig[{{dest_sig_idx}}] = '{{specialized_type_name}}'",
no_match = 'dest_sig[{{dest_sig_idx}}] = None',
nodes = [...]/2)
Compiler crash traceback from this point on:
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Compiler/FusedNode.py", line 62, in __init__
self.copy_cdef(env)
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Compiler/Symtab.py", line 259, in __repr__
return "%s(<%x>, name=%s, type=%s)" % (type(self).__name__, id(self), self.name, self.type)
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Compiler/PyrexTypes.py", line 301, in __str__
return self.declaration_code("", for_display = 1).strip()
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Compiler/PyrexTypes.py", line 3258, in declaration_code
arg_decl_list.append(self.op_arg_struct.declaration_code(Naming.optional_args_cname))
AttributeError: 'NoneType' object has no attribute 'declaration_code'
Traceback (most recent call last):
File "/home/althonos/Code/pyhmmer/setup.py", line 740, in <module>
setuptools.setup(
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/__init__.py", line 107, in setup
return distutils.core.setup(**attrs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
^^^^^^^^^^^^^^^^^^
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/dist.py", line 1234, in run_command
super().run_command(command)
File "/home/althonos/.local/lib/pypy3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/althonos/Code/pyhmmer/setup.py", line 133, in run
self.extensions = cythonize(self.extensions, **cython_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Build/Dependencies.py", line 1134, in cythonize
cythonize_one(*args)
File "/home/althonos/.local/lib/pypy3.10/site-packages/Cython/Build/Dependencies.py", line 1301, in cythonize_one
raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: pyhmmer/plan7.pyx
Expected behaviour
The Cython code (and the generated C code) compiles and works.
OS
Linux
Python version
Python 3.10.12 [PyPy 7.3.12 with GCC 13.1.1 20230429]
Cython version
3.0.0
Additional context
I actually tried modifying PyrexTypes.py:
cython/Cython/Compiler/PyrexTypes.py
Lines 3257 to 3258 in b4671ba
To check that self.op_arg_struct is not none:
if self.optional_arg_count and self.op_arg_struct is not None:
arg_decl_list.append(self.op_arg_struct.declaration_code(Naming.optional_args_cname))In that case I can compile both the Cython file and the resulting C code succesfully, but maybe that's just a hotfix and it breaks things elswehere 🤷 .