-
Notifications
You must be signed in to change notification settings - Fork 20
Comparing changes
Open a pull request
base repository: cyphar/filepath-securejoin
base: v0.3.3
head repository: cyphar/filepath-securejoin
compare: v0.3.4
- 11 commits
- 9 files changed
- 2 contributors
Commits on Sep 30, 2024
-
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 7302ab5 - Browse repository at this point
Copy the full SHA 7302ab5View commit details -
merge #31 into cyphar/filepath-securejoin:main
Aleksa Sarai (2): VERSION: back to development VERSION: release v0.3.3 LGTMs: cyphar
Configuration menu - View commit details
-
Copy full SHA for d0c7d67 - Browse repository at this point
Copy the full SHA d0c7d67View commit details -
openat: remove unused function
The only user of this function was dropped in commit 90adf5c ("mkdir: do not return errors for incorrect directory modes or owners") but we forgot to remove the function itself. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 4348fee - Browse repository at this point
Copy the full SHA 4348feeView commit details
Commits on Oct 4, 2024
-
Isolate the testing import in test code
testing_mocks_linux.go imports the testing package, and that import leaks into any binary built with securejoin. This causes issues in projects which check for that, such as Kubernetes (see kubernetes/kubernetes#127832 and its tests). This adds a level of indirection for hooks used to force testing behaviour in procfs_linux.go, so that the mocks can be defined only in _test.go files. This ensures that the testing package is only pulled in for tests. Signed-off-by: Stephen Kitt <skitt@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 6864912 - Browse repository at this point
Copy the full SHA 6864912View commit details
Commits on Oct 8, 2024
-
merge #32 into cyphar/filepath-securejoin:main
Stephen Kitt (1): Isolate the testing import in test code LGTMs: cyphar
Configuration menu - View commit details
-
Copy full SHA for 86e6182 - Browse repository at this point
Copy the full SHA 86e6182View commit details -
Ref: 6864912 ("Isolate the testing import in test code") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 3ec6eed - Browse repository at this point
Copy the full SHA 3ec6eedView commit details -
tests: procfs: clean up mock test hook
To make the code a little easier to follow, add some actual dummy functions that we assign to rather than re-using previous functions in a confusing way. Fixes: 6864912 ("Isolate the testing import in test code") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for ecb1b8e - Browse repository at this point
Copy the full SHA ecb1b8eView commit details -
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 205046f - Browse repository at this point
Copy the full SHA 205046fView commit details
Commits on Oct 9, 2024
-
README: fix reference to open_tree kernel requirements
open_tree(2) and fsopen(2) were added in Linux 5.2, not 4.18. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 0cd6be1 - Browse repository at this point
Copy the full SHA 0cd6be1View commit details -
godoc: update package documentation
The old documentation still referenced the filepath.SecureJoin proposal, which is long-dead. We should reference the new os.OpenRoot proposal as well as libpathrs. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 00e0710 - Browse repository at this point
Copy the full SHA 00e0710View commit details -
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for fd16ade - Browse repository at this point
Copy the full SHA fd16adeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.3.3...v0.3.4