Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cyphar/filepath-securejoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.3
Choose a base ref
...
head repository: cyphar/filepath-securejoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.4
Choose a head ref
  • 11 commits
  • 9 files changed
  • 2 contributors

Commits on Sep 30, 2024

  1. VERSION: back to development

    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7302ab5 View commit details
    Browse the repository at this point in the history
  2. merge #31 into cyphar/filepath-securejoin:main

    Aleksa Sarai (2):
      VERSION: back to development
      VERSION: release v0.3.3
    
    LGTMs: cyphar
    cyphar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d0c7d67 View commit details
    Browse the repository at this point in the history
  3. openat: remove unused function

    The only user of this function was dropped in commit 90adf5c
    ("mkdir: do not return errors for incorrect directory modes or owners")
    but we forgot to remove the function itself.
    
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4348fee View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Isolate the testing import in test code

    testing_mocks_linux.go imports the testing package, and that import
    leaks into any binary built with securejoin. This causes issues in
    projects which check for that, such as Kubernetes (see
    kubernetes/kubernetes#127832 and its tests).
    
    This adds a level of indirection for hooks used to force testing
    behaviour in procfs_linux.go, so that the mocks can be defined only in
    _test.go files. This ensures that the testing package is only pulled
    in for tests.
    
    Signed-off-by: Stephen Kitt <skitt@redhat.com>
    skitt committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6864912 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. merge #32 into cyphar/filepath-securejoin:main

    Stephen Kitt (1):
      Isolate the testing import in test code
    
    LGTMs: cyphar
    cyphar committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    86e6182 View commit details
    Browse the repository at this point in the history
  2. CHANGELOG: mention #32 fix

    Ref: 6864912 ("Isolate the testing import in test code")
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3ec6eed View commit details
    Browse the repository at this point in the history
  3. tests: procfs: clean up mock test hook

    To make the code a little easier to follow, add some actual dummy
    functions that we assign to rather than re-using previous functions in a
    confusing way.
    
    Fixes: 6864912 ("Isolate the testing import in test code")
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ecb1b8e View commit details
    Browse the repository at this point in the history
  4. README: add pkg.go.dev badge

    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    205046f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. README: fix reference to open_tree kernel requirements

    open_tree(2) and fsopen(2) were added in Linux 5.2, not 4.18.
    
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0cd6be1 View commit details
    Browse the repository at this point in the history
  2. godoc: update package documentation

    The old documentation still referenced the filepath.SecureJoin proposal,
    which is long-dead. We should reference the new os.OpenRoot proposal as
    well as libpathrs.
    
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    00e0710 View commit details
    Browse the repository at this point in the history
  3. VERSION: release v0.3.4

    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    cyphar committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fd16ade View commit details
    Browse the repository at this point in the history
Loading