Skip to content

Add tests for rose options being available in Cylc View #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Add tests for rose options being available in Cylc View #209

merged 1 commit into from
Feb 22, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Feb 15, 2023 •
edited
Loading

This is a small change with no associated Issue.

It tests cylc/cylc-flow#5367

n.b. Expected to fail tests prior to merge of #208

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to setup.cfg.
  • Is a test battery addition - no need to add changelog entry or docs

@wxtim wxtim requested review from datamel and MetRonnie February 15, 2023 09:24
@wxtim wxtim self-assigned this Feb 15, 2023
@wxtim wxtim added the small label Feb 15, 2023
@wxtim wxtim added this to the 1.2.x milestone Feb 15, 2023
@wxtim wxtim mentioned this pull request Feb 15, 2023
Merged
8 tasks
@MetRonnie
Copy link
Member

Kicking tests

@MetRonnie MetRonnie closed this Feb 16, 2023
@MetRonnie MetRonnie reopened this Feb 16, 2023
@wxtim wxtim changed the base branch from master to 1.1.x February 17, 2023 08:12
@wxtim wxtim changed the base branch from 1.1.x to master February 17, 2023 08:19
@wxtim wxtim force-pushed the add_test_for_rose_opts_for_cylc_view branch from 1682512 to 2dabf21 Compare February 17, 2023 08:20
@wxtim wxtim force-pushed the add_test_for_rose_opts_for_cylc_view branch from 2dabf21 to 2e7eec4 Compare February 17, 2023 08:21
@wxtim

This comment was marked as outdated.

Sign in to view
@MetRonnie MetRonnie merged commit f4977bd into cylc:master Feb 22, 2023
@MetRonnie MetRonnie modified the milestones: 1.2.x, 1.2.1 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@datamel datamel Awaiting requested review from datamel

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @MetRonnie