Skip to content

fix mypy fail caused by https://github.com/python/mypy/pull/13969 #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix mypy fail caused by https://github.com/python/mypy/pull/13969 #5350

merged 1 commit into from
Feb 7, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Feb 7, 2023

Small fix to ensure mypy works.

@wxtim wxtim requested a review from datamel February 7, 2023 11:39
@wxtim wxtim self-assigned this Feb 7, 2023
@wxtim wxtim added the bug? Not sure if this is a bug or not label Feb 7, 2023
@wxtim wxtim added this to the cylc-8.1.2 milestone Feb 7, 2023
@wxtim wxtim changed the base branch from master to 8.1.x February 7, 2023 11:39
datamel
datamel approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov upload error unrelated.

@datamel datamel merged commit d11d16f into cylc:8.1.x Feb 7, 2023
@wxtim wxtim deleted the fix_mypy branch February 7, 2023 11:47
@wxtim wxtim restored the fix_mypy branch February 7, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datamel datamel datamel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@wxtim wxtim

Labels
bug? Not sure if this is a bug or not
Projects
None yet
Milestone
cylc-8.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @datamel