Skip to content

Enhancements to dual-PPM (minor bug fix, web status) #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

yihchun
Copy link

@yihchun yihchun commented Feb 22, 2016

  • Skipping the stratux serial check when the other device is already bound. This prevents a misconfiguration (two SDRs with stratux:1090, for example) from blocking the second frequency from coming online.
  • Fix a special-case bug where id 0 is flexible and id 1 is hard-wired to UAT. Comments explain why the same special-case need not be applied to ES hard-wiring.
  • Added logging of serial numbers and PPMs per my comment on issue 1090 sdr not initiating with new per sdr ppm serial format  #275
  • Added SDRs active count to status page

Yih-Chun Hu added 3 commits February 21, 2016 23:59
…created.

  This prevents a misconfiguration (two SDRs with stratux:1090, for example)
  from blocking the second frequency from coming online.
- Added logging of serial numbers and PPMs per my comment on issue cyoung#275
- Added SDRs active count to status page
@jpoirier
Copy link
Collaborator

fyi - you'll need resubmit the appropriate parts once I get request #279 submitted; there are some significant changes

@@ -147,12 +149,14 @@ func getPPM(serial string) int {

func (e *ES) sdrConfig() (err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this function so empty compared to the func (u *UAT) sdrConfig() (err error)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we created our own Go wrapper around the dump978 tool (and compile it as a library) so we're able to configure the dongle internally (using gortlsdr) whereas we call the external dump1090 binary via exec.Command (shell command) and pass it options which it uses to configure the dongle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpoirier
Copy link
Collaborator

@yihchun it'd be great if you could review #279

@yihchun
Copy link
Author

yihchun commented Feb 22, 2016

Closing; will reimplement after #279 is merged.

@yihchun yihchun closed this Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants