Remove warnings when TLS verificaition is turned off when using a token / no CA file #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
I tested your changes but when I run the following: I am still getting the following errors in the beginning: How did you run it? Did you use docker or directly with python like I did? |
|
? |
g3rzi
approved these changes
Aug 25, 2022
|
We tested it on a new machine, it works fine. Thanks. |
|
awesome, glad you got it working 🎉 |
|
Thank you for the contribution, and sorry it took time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves the urllib3 warning suppression line to be enable automatically, when token auth is used. Should fix #5 . Tested with/without CA when using token. Have encountered no issues during my own testing.