This repository was archived by the owner on Mar 31, 2023. It is now read-only.
logWriter should buffers unwritten bytes
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nishitaniyuki |
ymmt2005
suggested changes
Sep 7, 2017
logger_test.go
Outdated
| type testFormat struct { | ||
| } | ||
|
|
||
| func (f *testFormat) String() string { |
There was a problem hiding this comment.
空 struct の場合ポインタ受けする必要もないので、
func (f testFormat) String() string で良いです。下も。
logger_test.go
Outdated
| l := NewLogger() | ||
| output := new(bytes.Buffer) | ||
| l.SetOutput(output) | ||
| l.SetFormatter(&testFormat{}) |
logger_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| actual := output.Bytes() | ||
| if bytes.Compare(actual, tc.Expected) != 0 { |
There was a problem hiding this comment.
ストレートに bytes.Equal があります。
https://golang.org/pkg/bytes/#Equal
logger_test.go
Outdated
| } | ||
| actual := output.Bytes() | ||
| if bytes.Compare(actual, tc.Expected) != 0 { | ||
| t.Errorf("actual: %s, expected: %s\n", string(actual), string(tc.Expected)) |
ymmt2005
approved these changes
Sep 7, 2017
|
LTGM. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logWriter.WriteLogger.Writer