hcl: When writting Module variables normalize the names #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6188405 to
3e9bf14
Compare
xlr-8
reviewed
Aug 30, 2021
util/name.go
Outdated
|
|
||
| var invalidNameRegexp = regexp.MustCompile(`[^a-z0-9_]`) | ||
|
|
||
| // NormalizeName will convert the n into an low case alphanymeric value |
There was a problem hiding this comment.
a lower-case alphanumeric* ?
I guess it's normal for empty string not to be checked here?
There was a problem hiding this comment.
I would say yes, it's a helper to normalize things.
As in some cases, like 'tags', they have keys that cannot be converted direclty into valirables names so we have to normailze them. For this we reused the 'tag' logic and abstracted it to the 'util' lib so it can be shared between the 2 packages
d45609f to
c3d0094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in some cases, like 'tags', they have keys that cannot be converted directly into variables names
so we have to normalize them.
For this we reused the 'tag' logic and abstracted it to the 'util' lib so it can be shared between the 2 packages
Closes #218