Skip to content

tag: Try to remove invalid characters from name #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

tag: Try to remove invalid characters from name #211

merged 1 commit into from
Aug 9, 2021

Conversation

xescugc
Copy link
Member

@xescugc xescugc commented Jul 29, 2021

Instead of jumping to the fallback first we try to clean the name of invalid characters

Closes #208

@xescugc xescugc self-assigned this Jul 29, 2021
@xescugc
tag: Try to remove invalid characters from name
7cc5181 
Instead of jumping to the fallback first we try to clean the name of invalid characters
@xescugc
Copy link
Member Author

xescugc commented Jul 30, 2021

I made a small change in which instead of removing invalid values we replace them for _ which is much more readable.

@xescugc xescugc merged commit 666b87f into master Aug 9, 2021
@xescugc xescugc deleted the fg-208 branch August 9, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerak19 kerak19 kerak19 approved these changes

Assignees

@xescugc xescugc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve resource naming
3 participants
@xescugc @kerak19 @xlr-8