-
Notifications
You must be signed in to change notification settings - Fork 24
Description
I have an app with a bunch of nested components and have found that when I use cyclic-router, the component that's being loaded (Welcome
) gets called twice, causing isolated child components with implicit scopes (e.g. export default sources => isolate(UserProfile)(sources)
) lose track of their scope because it seems the scopes are recalculated when the component is reran.
If you git clone
https://github.com/wyqydsyq/hapi-cycle, run npm install && npm run launch
and then visit http://localhost:1337/ you can see the UI in this case works fine, but if you then swap the part of https://github.com/wyqydsyq/hapi-cycle/blob/master/src/ui/app.js that returns just the component with the commented out lines to make it use cyclic-router instead of calling the component directly, subcomponents will no longer emit/recieve events from/to themselves.
Using explicit scopes seems to remedy this, as each isolated child component would be using the same scope string in between calling the main component, but that's more of a band-aid fix than a solution.
So the working/not working cases for me are:
- ✅ Router with explicit isolation scope on child components
- ✅ No router (calling component directly) with implied isolation scope on child components
- ❎ Router with implied isolation scope on child components