Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 27, 2022

Description

A new '''cylp''' release, https://pypi.org/project/cylp/0.91.5/, fixes the broken integer infeasibility detection with CBC (#1705). Thanks @tkralphs!
We set a corresponding lower version bound in extras_require for '''cylp'''.

Also remove handling of a misspelled cylp problem status (#1707). The typo has not made it into a cylp release.

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@SteveDiamond
Copy link
Collaborator

Thanks!

@SteveDiamond SteveDiamond merged commit c1a06c1 into cvxpy:master Mar 27, 2022
SteveDiamond added a commit that referenced this pull request Apr 24, 2022
…github.com:cvxpy/cvxpy

* 'master' of github.com:QiuWJX/cvxpy:
  changed the copyright and docstring
  create resources folder in codes
  undid changes
  standardized the code style created a folder called ./cvxpy/tests/resources/
  Add unit test for gurobi `model.write()`
  Add 'save_file' kwargs for GUROBI. - use Gurobi.write(save_file) to save the model file. - cplex and mosek have the similar functionality.
  cvxpy/tests: Add test for infeasible boolean problem (#1705)
  Handle new CyLP statuses from coin-or/CyLP#150 (#1707)

* 'master' of github.com:cvxpy/cvxpy:
  SCIP: add version requirement (< 4.0.0) and fix solve_via_data to eliminate certain error messages
  update error message for mixed-integer problems (#1738)
  remove out of date news
  fix TypeError in GLOP and PDLP interfaces (#1736)
  Propagate today's documentation improvements from release/1.2.x (#1733)
  Cylp update (#1727)
  Add 'save_file' kwargs for GUROBI. (#1720)
  pip install cvxpy[GLOP,XPRESS] (#1719)
  Fix #1714
  cvxpy/tests: Add test for infeasible boolean problem (#1705)
  Handle new CyLP statuses from coin-or/CyLP#150 (#1707)
@rileyjmurray
Copy link
Collaborator

rileyjmurray commented May 16, 2022

Actually, CVXPY 1.1.X doesn't support installing solvers by setup_requires in setup.cfg. So this fix (consisting of a version lower bound for cylp and removing a solver status) can't be implemented for 1.1.X.

This fix can (and should) be propagated to 1.2.X.

@rileyjmurray
Copy link
Collaborator

I was wrong with my last comment. The ability to use setup_requires in setup.cfg was introduced after the release of 1.2.0. So this PR shouldn't appear in the 1.2.X release series.

@mkoeppe mkoeppe deleted the cylp_update branch May 1, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants