Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 20, 2022

Description

Please include a short summary of the change.
Issue link (if applicable):
Add extras_require mapping solver names to the pip-installable distribution providing it

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@SteveDiamond
Copy link
Collaborator

This is very interesting! If we make this change, we should update the install guide. Also, mosek can be pip installed (though you need a license to solve anything).

@SteveDiamond
Copy link
Collaborator

This looks fine to me. @rileyjmurray what do you think?

Copy link
Collaborator

@rileyjmurray rileyjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left comments about sdpt3glue and DSDP. Please respond to those in one form or another.

@rileyjmurray rileyjmurray merged commit 30f8e04 into cvxpy:master Mar 22, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 22, 2022

Thanks for the fix for the documentation, which I had forgotten

@mkoeppe mkoeppe deleted the extras_require branch March 22, 2022 23:45
@rileyjmurray
Copy link
Collaborator

You're welcome! Thanks for the PR :)

SteveDiamond added a commit that referenced this pull request Apr 24, 2022
…github.com:cvxpy/cvxpy

* 'master' of github.com:QiuWJX/cvxpy:
  changed the copyright and docstring
  create resources folder in codes
  undid changes
  standardized the code style created a folder called ./cvxpy/tests/resources/
  Add unit test for gurobi `model.write()`
  Add 'save_file' kwargs for GUROBI. - use Gurobi.write(save_file) to save the model file. - cplex and mosek have the similar functionality.
  cvxpy/tests: Add test for infeasible boolean problem (#1705)
  Handle new CyLP statuses from coin-or/CyLP#150 (#1707)

* 'master' of github.com:cvxpy/cvxpy:
  SCIP: add version requirement (< 4.0.0) and fix solve_via_data to eliminate certain error messages
  update error message for mixed-integer problems (#1738)
  remove out of date news
  fix TypeError in GLOP and PDLP interfaces (#1736)
  Propagate today's documentation improvements from release/1.2.x (#1733)
  Cylp update (#1727)
  Add 'save_file' kwargs for GUROBI. (#1720)
  pip install cvxpy[GLOP,XPRESS] (#1719)
  Fix #1714
  cvxpy/tests: Add test for infeasible boolean problem (#1705)
  Handle new CyLP statuses from coin-or/CyLP#150 (#1707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants