Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 13, 2022

Description

Please include a short summary of the change.
Issue link (if applicable):

coin-or/CyLP#81
@tkralphs

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2022

CLA assistant check
All committers have signed the CLA.

@SteveDiamond
Copy link
Collaborator

Thanks for contributing! This fix doesn't seem to work in all cases. You can see the tests that failed.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 14, 2022

Thanks for contributing! This fix doesn't seem to work in all cases. You can see the tests that failed.

Yes, the fix is not correct as is. A proper fix will need to go through coin-or/CyLP#150, #1707

@rileyjmurray
Copy link
Collaborator

rileyjmurray commented Mar 16, 2022

I believe this has been superseded by #1705, so I'll close this for now. @mkoeppe let me know if I jumped the gun here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants