Skip to content

fix gopher don't send NUL byte bug #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix gopher don't send NUL byte bug #466

wants to merge 3 commits into from

Conversation

orangetw
Copy link
Contributor

@orangetw orangetw commented Oct 1, 2015

I find that gopher scheme (gopher://) do not support NUL byte.
I read the source code and find that gopher.c use STRLEN(SEL) to process the URL-DECODED data.
But "curl_easy_unescape" already has specified OUTLENGTH. so I change the STRLEN(SEL) to OUTLENGTH.

@bagder bagder closed this in 5bf36ea Oct 1, 2015
@bagder
Copy link
Member

bagder commented Oct 1, 2015

Thanks a lot!

jgsogo pushed a commit to jgsogo/curl that referenced this pull request Oct 19, 2015
@orangetw @jgsogo
gopher: don't send NUL byte
58f9912 
Closes curl#466
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangetw @bagder