-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Description
Hi,
Port of Curl 7.43.0 on AIX is OK, except that test 1902 succeeds randomly (2 success out of 50 runs), instead of 100% success on Ubuntu/Intel.
I think that the issue deals with the way the expected data and the generated data are compared.
test 1902...[HTTP GET using pipelining, broken pipe]
1902: data FAILED:
--- log/check-expected 2015-07-24 14:15:47 +0200
+++ log/check-generated 2015-07-24 14:15:47 +0200
@@ -6,9 +6,9 @@
Adding handle 4[LF]
Adding handle 5[LF]
Adding handle 6[LF]
-Handle 1 Completed with status 0[LF]
Handle 4 Completed with status 0[LF]
Handle 5 Completed with status 0[LF]
Handle 6 Completed with status 0[LF]
+Handle 1 Completed with status 0[LF]
Handle 2 Completed with status 0[LF]
Handle 3 Completed with status 0[LF]
Looking at these 2 files, they only differ due to the ordering of the lines, which depends on when each parallel sub-response ends.
Expected:
Handle 1 Completed with status 0[LF]
Handle 4 Completed with status 0[LF]
Handle 5 Completed with status 0[LF]
Handle 6 Completed with status 0[LF]
Handle 2 Completed with status 0[LF]
Handle 3 Completed with status 0[LF]
Generated:
Handle 4 Completed with status 0[LF]
Handle 5 Completed with status 0[LF]
Handle 6 Completed with status 0[LF]
Handle 1 Completed with status 0[LF]
Handle 2 Completed with status 0[LF]
Handle 3 Completed with status 0[LF]
In getpart.pm there is a showdiff routine, which does:
diff -u $file2 $file1 2>/dev/null
Sorting the 2 files log/check-expected log/check-generated
before comparing them does fix the issue.