Skip to content

Support for shape argument in *_like functions #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 20, 2019
Merged

Support for shape argument in *_like functions #2171

merged 14 commits into from
Aug 20, 2019

Conversation

pentschev
Copy link
Member

Add support for overriding the shape of the input array when calling empty_like(), as recently added to NumPy API in numpy/numpy#13046, starting from NumPy 1.17.

@pentschev pentschev mentioned this pull request May 6, 2019
Closed
19 tasks
toslunar
toslunar requested changes May 7, 2019
View reviewed changes
kmaehashi
kmaehashi reviewed May 7, 2019
View reviewed changes
@pentschev
Copy link
Member Author

All change requests have been addressed.

Please note I had to retrigger the build, due to AppVeyor timing out when downloading NumPy. For future reference, is there a way to trigger another build without pushing a commit?

@kmaehashi
Copy link
Member

Please note I had to retrigger the build, due to AppVeyor timing out when downloading NumPy. For future reference, is there a way to trigger another build without pushing a commit?

Unfortunately contributors cannot retrigger the test.
Reviewers will take care of it, so please avoid pushing dummy commit to keep git history clean :)

@kmaehashi
Copy link
Member

This PR implements the spec of unreleased version of NumPy. We agreed to include this into the master branch. This PR can be backported to the stable branch (v6) once after the corresponding version of NumPy has been released.

@pentschev
Copy link
Member Author

Unfortunately contributors cannot retrigger the test.
Reviewers will take care of it, so please avoid pushing dummy commit to keep git history clean :)

Thanks for letting me know, and sorry for jumping in and pushing that commit unnecessarily.

@pentschev pentschev mentioned this pull request May 22, 2019
Closed
@pentschev pentschev mentioned this pull request May 29, 2019
Closed
@toslunar toslunar self-requested a review May 31, 2019 08:41
@pentschev pentschev mentioned this pull request Jun 7, 2019
Closed
kmaehashi
kmaehashi requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except commented.

cupy/creation/basic.py Outdated
@@ -55,6 +62,11 @@ def empty_like(a, dtype=None, order='K'):
result. 'C' means C-order, 'F' means F-order, 'A' means 'F' if
``a`` is Fortran contiguous, 'C' otherwise. 'K' means match the
layout of ``a`` as closely as possible.
subok: Not supported yet, must be None.
shape (tuple of ints): Overrides the shape of the result. If order='K'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be int or tuple of ints.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. You're right, I had that copied from the docs of empty (and similar) that don't include that information. I pushed a new commit to add that missing information to docs of all those functions now.

@pentschev
Copy link
Member Author

Looks like the failure was due to a network issue, could you retrigger @kmaehashi ?

This was referenced Jul 7, 2019
Closed
Open
@kmaehashi
Copy link
Member

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit e8019a1:

@kmaehashi kmaehashi added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch labels Jul 16, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit e8019a1, target branch master) succeeded!

toslunar
toslunar approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev
Copy link
Member Author

Is there anything else to do here, or could this be merged now that NumPy 1.17 is out?

@jakirkham
Copy link
Member

@kmaehashi, is this ok to go in or do you need something else from us?

@pentschev
Copy link
Member Author

I think 6.3.0 should be release soon, right? It would be great if we could have this merged before that!

@kmaehashi kmaehashi merged commit 475d129 into cupy:master Aug 20, 2019
@kmaehashi kmaehashi added this to the v7.0.0b3 milestone Aug 20, 2019
kmaehashi added a commit to kmaehashi/cupy that referenced this pull request Aug 20, 2019
@kmaehashi
Merge pull request cupy#2171 from pentschev/array-like-creation-shape…
4659037 
…-support

Support for shape argument in *_like functions
@kmaehashi kmaehashi mentioned this pull request Aug 20, 2019
Merged
@pentschev pentschev mentioned this pull request Nov 8, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi requested changes

@toslunar toslunar toslunar approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v7.0.0b3
Development

Successfully merging this pull request may close these issues.
6 participants
@pentschev @kmaehashi @pfn-ci-bot @chainer-ci @jakirkham @toslunar