Skip to content

fix(types): improve higher-order combinator TS types #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2017
Merged

fix(types): improve higher-order combinator TS types #483

merged 1 commit into from
Aug 27, 2017

Conversation

briancavalier
Copy link
Member

Summary

Use TS this argument type to provide correct types for higher-order methods join, switch, etc. in the same way that awaitPromises does.

Frikki
Frikki approved these changes Aug 27, 2017
View reviewed changes
Copy link
Collaborator

@Frikki Frikki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

davidchase
davidchase approved these changes Aug 27, 2017
View reviewed changes
Copy link
Collaborator

@davidchase davidchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@briancavalier briancavalier merged commit 097ed3b into master Aug 27, 2017
@briancavalier briancavalier deleted the update-ts-hos-method-types branch August 27, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frikki Frikki Frikki approved these changes

@davidchase davidchase davidchase approved these changes

@TylorS TylorS Awaiting requested review from TylorS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briancavalier @Frikki @davidchase