Skip to content

some commits related with security audit #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2023
Merged

some commits related with security audit #2824

merged 5 commits into from
Dec 11, 2023

Conversation

leonrayang
Copy link
Member

@leonrayang leonrayang commented Nov 29, 2023 •
edited
Loading

What this PR does / why we need it:
[fix(metanode):add lock release before panic for security]
(dcb5ee8)

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 8ba5d4b
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/65766d74bd857a0008b6c8ec
😎 Deploy Preview https://deploy-preview-2824--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (126cef4) 41.86% compared to head (4809f03) 41.86%.
Report is 1 commits behind head on master.

❗ Current head 4809f03 differs from pull request most recent head 8ba5d4b. Consider uploading reports for the commit 8ba5d4b to get more accurate results

Files Patch % Lines
objectnode/server.go 0.00% 4 Missing ⚠️
objectnode/acl_api.go 0.00% 3 Missing ⚠️
metanode/inode.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2824   +/-   ##
=======================================
  Coverage   41.86%   41.86%           
=======================================
  Files         574      574           
  Lines      118705   118718   +13     
=======================================
+ Hits        49692    49698    +6     
- Misses      64754    64759    +5     
- Partials     4259     4261    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonrayang leonrayang changed the title fix(metanode/datanode): adjust extent space size base on snapshot and fix deadlock on metanode fix(master):qos.Lock of assignClientsNewQos forget release and trigger deadlock Dec 8, 2023
true1064
true1064 previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@true1064 true1064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuqiang-zheng
shuqiang-zheng previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@shuqiang-zheng shuqiang-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonrayang leonrayang dismissed stale reviews from shuqiang-zheng and true1064 via dcb5ee8 December 9, 2023 04:51
@leonrayang leonrayang changed the title fix(master):qos.Lock of assignClientsNewQos forget release and trigger deadlock fix(metanode):add lock release before panic for security Dec 9, 2023
@leonrayang leonrayang changed the title fix(metanode):add lock release before panic for security some commits related with security audit Dec 9, 2023
Victor1319
Victor1319 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Victor1319 Victor1319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonrayang @true1064
fix(metanode):add lock release before panic for security
6ee68cd 
Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang @true1064
fix(object): unmarshal may return nil althrough no error happend
7be24e8 
Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang @true1064
enhance(httpserver):resolve Potential Slowloris attacks according to …
36715b7 
…ostif security team

Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang @true1064
fix(master):CubeFS leaks users key in logs
2436913 
Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang @true1064
enhance(security document): Add note for user report private security…
8ba5d4b 
… issues with groups.io

Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang leonrayang merged commit feea466 into cubefs:master Dec 11, 2023
@bboyCH4 bboyCH4 added this to the release-3.3.1 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@true1064 true1064 true1064 approved these changes

@Victor1319 Victor1319 Victor1319 approved these changes

@shuqiang-zheng shuqiang-zheng shuqiang-zheng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-3.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@leonrayang @true1064 @Victor1319 @shuqiang-zheng @bboyCH4