Skip to content

Conversation

mawei029
Copy link
Collaborator

@mawei029 mawei029 commented Nov 22, 2023

What this PR does / why we need it:
fix blobnode deadlock from cubefs-draft-security-audit-report

Which issue this PR fixes:

fixes #2791

Special notes for your reviewer:

Release note:

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 5be9045
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/655d9c335eb7360008708818
😎 Deploy Preview https://deploy-preview-2790--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JasonHu520
JasonHu520 previously approved these changes Nov 22, 2023
sejust
sejust previously approved these changes Nov 22, 2023
@mawei029 mawei029 dismissed stale reviews from sejust and JasonHu520 via 5fa15cf November 22, 2023 03:41
@mawei029 mawei029 force-pushed the mwgit_master_fixdeadlock branch from 34817c4 to 5fa15cf Compare November 22, 2023 03:41
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8342718) 41.83% compared to head (5be9045) 41.79%.

Files Patch % Lines
blobstore/blobnode/work_shard_recover.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
- Coverage   41.83%   41.79%   -0.05%     
==========================================
  Files         573      573              
  Lines      118066   118067       +1     
==========================================
- Hits        49398    49342      -56     
- Misses      64436    64492      +56     
- Partials     4232     4233       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mawei029 mawei029 requested a review from JasonHu520 November 22, 2023 04:45
@mawei029 mawei029 force-pushed the mwgit_master_fixdeadlock branch from 5fa15cf to 0013ee9 Compare November 22, 2023 04:52
Copy link
Collaborator

@tangdeyi tangdeyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: mawei029 <mawei2@oppo.com>
@mawei029 mawei029 force-pushed the mwgit_master_fixdeadlock branch from 0013ee9 to 5be9045 Compare November 22, 2023 06:14
@mawei029 mawei029 merged commit 1f8070d into cubefs:master Nov 22, 2023
@bboyCH4 bboyCH4 added this to the release-3.3.1 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: deadlock may happen in blobnode when it put shard, reported by CNCF
5 participants