Skip to content

enhance(gapi):Timing attack can leak user passwords and CubeFS leaks users key in logs from cncf security audit #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

leonrayang
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes:
from cncf security audit:
Timing attack can leak user passwords

Signed-off-by: leonrayang <chl696@sina.com>
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop-v3.3.1@f9ea047). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             develop-v3.3.1    #2781   +/-   ##
=================================================
  Coverage                  ?   41.13%           
=================================================
  Files                     ?      520           
  Lines                     ?   103759           
  Branches                  ?        0           
=================================================
  Hits                      ?    42679           
  Misses                    ?    57496           
  Partials                  ?     3584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang leonrayang changed the title enhance(gapi):Timing attack can leak user passwords enhance(gapi):Timing attack can leak user passwords and CubeFS leaks users key in logs from cncf security audit Nov 17, 2023
Copy link
Collaborator

@baijiaruo baijiaruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baijiaruo baijiaruo merged commit 8dccce6 into cubefs:develop-v3.3.1 Nov 17, 2023
@bboyCH4 bboyCH4 added this to the release-3.3.1 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants