Skip to content

fix(objectnode): fix read body entirely into memory #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(objectnode): fix read body entirely into memory #2691

merged 1 commit into from
Oct 20, 2023

Conversation

tangdeyi
Copy link
Collaborator

@tangdeyi tangdeyi commented Oct 20, 2023 •
edited
Loading

fix read body entirely into memory

Security issue: GHSA-qc6v-g3xw-grmx

@tangdeyi
fix(objectnode): fix read body entirely into memory and without an up…
17f6b1f 
…per boundary

Signed-off-by: tangdeyi <tangdeyi@oppo.com>
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 17f6b1f
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/65322fb3ca07b100083fcd9a
😎 Deploy Preview https://deploy-preview-2691--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tangdeyi tangdeyi changed the title fix(objectnode): fix read body entirely into memory and without an up… fix(objectnode): fix read body entirely into memory Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2691 (17f6b1f) into master (972f027) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   42.17%   42.17%           
=======================================
  Files         568      568           
  Lines      116950   116987   +37     
=======================================
+ Hits        49319    49337   +18     
- Misses      63389    63411   +22     
+ Partials     4242     4239    -3
Files Coverage Δ
objectnode/lifecycle_handler.go 0.00% <0.00%> (ø)
objectnode/api_handler_multipart.go 0.00% <0.00%> (ø)
objectnode/api_handler_bucket.go 0.00% <0.00%> (ø)
objectnode/api_handler_object.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

honeyvinnie
honeyvinnie approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@honeyvinnie honeyvinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangdeyi tangdeyi added the security Topic about security and authorization label Oct 20, 2023
yhjiango
yhjiango approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@yhjiango yhjiango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonrayang leonrayang merged commit dd46c24 into cubefs:master Oct 20, 2023
@bboyCH4 bboyCH4 added this to the release-3.3.1 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeyvinnie honeyvinnie honeyvinnie approved these changes

@yhjiango yhjiango yhjiango approved these changes

@leonrayang leonrayang Awaiting requested review from leonrayang

Assignees
No one assigned
Labels
security Topic about security and authorization
Projects
None yet
Milestone
release-3.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@tangdeyi @honeyvinnie @yhjiango @leonrayang @bboyCH4