[Enhancement]: Optimize insecure random number generation in function … util/string.go:RandomString #2698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
- Coverage 42.13% 42.12% -0.02%
==========================================
Files 568 568
Lines 117072 117074 +2
==========================================
- Hits 49334 49316 -18
- Misses 63501 63525 +24
+ Partials 4237 4233 -4
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… util/string.go:RandomString close: cubefs#2696 Signed-off-by: true1064 <tangjingyu@oppo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refer fo https://github.com/cubefs/cubefs/security/advisories/GHSA-4248-p65p-hcrm
function RandomString in util/string.go is insecure，for it is using pseudorandom generator and time stamp as random seed, this could allow an attacker to predict and/or guess the generated string.
shuold replace the pseudorandom generator withTrue Random Number Generator.
Which issue this PR fixes:
fixes #2696