Skip to content

Conversation

true1064
Copy link
Contributor

@true1064 true1064 commented Oct 11, 2023

What this PR does / why we need it:
feat(master/datanode/cli):
(1)datanode bad disk report to master adds: TotalPartititionCnt and DiskErrPartitionList
(2)cfs-cli display bad disk adds TotalPartititionCnt and DiskErrPartitionList accordingly
(3)datanode's data partition add disk err count record and log print

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 45f38c0
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/65276e1da4248100086607ec
😎 Deploy Preview https://deploy-preview-2679--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2679 (45f38c0) into master (f11a238) will increase coverage by 0.05%.
The diff coverage is 3.61%.

@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
+ Coverage   42.07%   42.12%   +0.05%     
==========================================
  Files         566      566              
  Lines      116186   116212      +26     
==========================================
+ Hits        48887    48960      +73     
+ Misses      63089    63041      -48     
- Partials     4210     4211       +1     
Files Coverage Δ
datanode/server.go 0.00% <ø> (ø)
master/data_node.go 48.50% <100.00%> (+0.42%) ⬆️
proto/admin_proto.go 0.00% <ø> (ø)
proto/model.go 0.00% <ø> (ø)
datanode/partition_raftfsm.go 0.00% <0.00%> (ø)
datanode/wrap_operator.go 0.00% <0.00%> (ø)
master/api_service.go 24.94% <0.00%> (-0.03%) ⬇️
datanode/space_manager.go 0.00% <0.00%> (ø)
datanode/partition.go 0.00% <0.00%> (ø)
datanode/disk.go 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

(1)datanode bad disk report to master adds: TotalPartititionCnt and DiskErrPartitionList
(2)cfs-cli display bad disk adds TotalPartititionCnt and DiskErrPartitionList accordingly
(3)datanode's data partition add disk err count record and log print

Signed-off-by: true1064 <tangjingyu@oppo.com>
Copy link
Member

@Victor1319 Victor1319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@true1064 true1064 merged commit a5dd54d into cubefs:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants