Skip to content

Conversation

yihong0618
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 requested a review from a team as a code owner January 12, 2025 06:52
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jan 12, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (8d714d6) to head (52d3984).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9092      +/-   ##
==========================================
- Coverage   82.84%   79.95%   -2.90%     
==========================================
  Files         222      222              
  Lines       78828    78828              
==========================================
- Hits        65308    63026    -2282     
- Misses      13520    15802    +2282     
Flag Coverage Δ
cubesql 79.95% <100.00%> (-2.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon changed the title fix: typo for DBeaver in comments change DBEver to DBeaver chore(cubesql): Fix typo for DBeaver in comments Jan 17, 2025
@KSDaemon
Copy link
Member

@yihong0618 Thnx for fixing this!

@KSDaemon KSDaemon merged commit aab9e8f into cube-js:master Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants