Skip to content

Annotate controllers and helpers #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2015
Merged

Annotate controllers and helpers #299

merged 2 commits into from
Dec 3, 2015

Conversation

djsegal
Copy link
Contributor

@djsegal djsegal commented Dec 2, 2015

Resolves #293:

I thought it might be useful to add annotations to helpers and controllers.

The next question is do we allow everything that can be generated to be annotated?

This includes:

  • javascript assets
  • stylesheet assets
  • migrations themselves
  • [js/html/json] . erb/jbuilder files for
    • index
    • show
    • edit
    • _form

@djsegal djsegal changed the title Annotate controllers and helpers – #293 Annotate controllers and helpers Dec 2, 2015
@ctran
Copy link
Owner

ctran commented Dec 2, 2015

I don't think it makes sense to annotate everything, especially when they are not "rb" files. I'm already not sure about controllers and helpers. Do you find them helpful? What do others think?

@ctran ctran added the feature label Dec 2, 2015
@ctran ctran added this to the v2.7.0 milestone Dec 2, 2015
ctran added a commit that referenced this pull request Dec 3, 2015
@ctran
Merge pull request #299 from djsegal/develop
a0682a4 
Annotate controllers and helpers
@ctran ctran merged commit a0682a4 into ctran:develop Dec 3, 2015
@djsegal
Copy link
Contributor Author

djsegal commented Dec 8, 2015

@ctran:

  • one reason I use annotate is because its a subtle reminder to update every file related to a model.
  • i do agree that some files may be overkill, i just wanted to see if annotate should be able to touch everything made from a rails g blank ....

@ctran ctran mentioned this pull request Dec 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djsegal @ctran