This repository was archived by the owner on Nov 17, 2024. It is now read-only.
⚡ Introduces ct.keyboard.permitDefault and ct.pointer.permitDefault #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmoMyzrailGorynych
suggested changes
Sep 16, 2023
There was a problem hiding this comment.
I like the idea, but I don't like the placement of the setting. For ct.js v3, I would put it in ct.pointer and ct.touch. For v4, there will be a special settings object, buuut its API is yet to be formed.
I can approve this PR, but you still need to make a sister PR for docs.ctjs.rocks.
CosmoMyzrailGorynych
approved these changes
Sep 17, 2023
CosmoMyzrailGorynych
pushed a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often I only need the user to be able to use the default browser actions on one or two room.
For example to scroll through the achievements or to enter a high score.
This pull request introduces a boolean
ct.permitDefaultthat can be set totruewhen calls toe.preventDefault();should be suspended. The feature is implemented acrossct.touch,ct.mouse,ct.pointerandct.keyboard.Incidentally (but unrelated to the PR)
ct.pointerdoes not work on iOS, so please keepct.toucharound until Safari sorts this out.This is another pull request in my attempts to cherry pick the most mature fixes from this branch and generate pull requests for them.