FIX: [sync] handle MySQL duplicate entry errors during record insertion #2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
May 19, 2025
pkg/service/sync_task.go
Outdated
| } | ||
| if isMysqlDuplicateError(err, logger) { | ||
| // ignore duplicate error | ||
| logger.Infof("duplicate entry for %T, skipped: %+v", obj, obj) |
c9s
reviewed
May 19, 2025
pkg/service/sync_task.go
Outdated
| logger.Infof("duplicate entry for %T, skipped: %+v", obj, obj) | ||
| continue | ||
| } else if err != nil { | ||
| logger.WithError(err).Errorf("can not insert record: %v", obj) |
c9s
reviewed
May 19, 2025
pkg/service/sync_task.go
Outdated
| // "Error 1062 (23000): Duplicate entry" | ||
| if parentErr := errors.Unwrap(err); parentErr != nil { | ||
| if mysqlErr, ok := parentErr.(*mysql.MySQLError); ok { | ||
| logger.Errorf("matched MySQLError: %+v", mysqlErr) |
c9s
reviewed
May 19, 2025
pkg/service/sync_task.go
Outdated
| } | ||
| } | ||
|
|
||
| matched, _ := regexp.MatchString("Duplicate entry", err.Error()) |
8efe65c to
a3dded2
Compare
c9s
approved these changes
May 19, 2025
a3dded2 to
d53ab18
Compare
ycdesu
approved these changes
May 19, 2025
gx578007
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.