Skip to content

FIX: [binance] fix binance risk position side convert to global #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

FIX: [binance] fix binance risk position side convert to global #2033

merged 1 commit into from
May 16, 2025

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented May 14, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.88%. Comparing base (f7d7e1a) to head (de9d59e).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
pkg/exchange/binance/convert_futures.go 55.55% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
+ Coverage   22.81%   22.88%   +0.07%     
==========================================
  Files         677      677              
  Lines       52652    52661       +9     
==========================================
+ Hits        12014    12054      +40     
+ Misses      39766    39735      -31     
  Partials      872      872
Files with missing lines Coverage Δ
pkg/exchange/binance/convert_futures.go 16.73% <55.55%> (+1.18%) ⬆️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d50e11...de9d59e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@c9s c9s merged commit 0179dd4 into c9s:main May 16, 2025
5 checks passed
@anywhy anywhy deleted the fix_binance_position_convert branch August 1, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anywhy @c9s