Skip to content

FEATURE: [coinbase] integrate TickKLineDriver with kline stream subscription #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

FEATURE: [coinbase] integrate TickKLineDriver with kline stream subscription #2031

merged 1 commit into from
May 19, 2025

Conversation

dboyliao
Copy link
Collaborator

No description provided.

zenixls2
zenixls2 reviewed May 14, 2025
View reviewed changes
@zenixls2
Copy link
Collaborator

Is SerialMarketDataStore used elsewhere?
If not, maybe time to remove the implementation?
cc @c9s

@dboyliao dboyliao force-pushed the dboy/core-kline-builder branch from a5daccc to 1cf5139 Compare May 14, 2025 09:03
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch from 011be75 to bd48616 Compare May 14, 2025 09:29
@dboyliao dboyliao force-pushed the dboy/core-kline-builder branch from 1cf5139 to ad42b61 Compare May 14, 2025 09:43
@dboyliao dboyliao requested a review from zenixls2 May 14, 2025 09:52
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch from bd48616 to 08b75eb Compare May 14, 2025 10:14
@dboyliao dboyliao force-pushed the dboy/core-kline-builder branch from ad42b61 to 78a9d6a Compare May 14, 2025 14:10
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch from 08b75eb to c09c487 Compare May 14, 2025 14:11
@dboyliao dboyliao force-pushed the dboy/core-kline-builder branch from 78a9d6a to 0ff759f Compare May 14, 2025 23:55
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch 2 times, most recently from f906cfb to fa34d9e Compare May 15, 2025 01:10
@dboyliao
Copy link
Collaborator Author

dboyliao commented May 15, 2025 •
edited
Loading

@zenixls2
As far as I know, SerialMarketDataStore is still used in several strategies, such as drift and elliottwave.
Though it should be able to be replaced by the tick kline driver, let's leave it as is for now.

Base automatically changed from dboy/core-kline-builder to main May 15, 2025 06:21
@dboyliao dboyliao marked this pull request as ready for review May 15, 2025 06:21
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch from fa34d9e to 4c99d9b Compare May 15, 2025 06:49
@dboyliao dboyliao force-pushed the dboy/coinbase-kline-v2 branch from 4c99d9b to 0a0a1bf Compare May 19, 2025 03:23
@dboyliao dboyliao merged commit 635db6f into main May 19, 2025
3 checks passed
@dboyliao dboyliao deleted the dboy/coinbase-kline-v2 branch May 19, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@zenixls2 zenixls2 zenixls2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dboyliao @zenixls2 @c9s