REFACTOR: [types] move MarketDataStore/SerialMarketDataStore to types module
#2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
May 5, 2025
pkg/types/serialmarketdatastore.go
Outdated
| @@ -43,7 +44,7 @@ func (store *SerialMarketDataStore) Subscribe(interval types.Interval) { | |||
| store.Subscription = append(store.Subscription, interval) | |||
| } | |||
|
|
|||
| func (store *SerialMarketDataStore) BindStream(ctx context.Context, stream types.Stream) { | |||
| func (store *SerialMarketDataStore) BindStream(ctx context.Context, stream Stream) { | |||
| if store.UseMarketTrade { | |||
| if IsBackTesting { | |||
There was a problem hiding this comment.
perhaps remove this condition to simplify the package import
There was a problem hiding this comment.
I'll comment out this first.
Let's see if we need to add it back in the future.
c9s
reviewed
May 5, 2025
pkg/bbgo/environment.go
Outdated
| @@ -49,6 +49,7 @@ var BackTestService *service.BacktestService | |||
| func SetBackTesting(s *service.BacktestService) { | |||
| BackTestService = s | |||
| IsBackTesting = s != nil | |||
| types.IsBackTesting = IsBackTesting | |||
c9s
approved these changes
May 5, 2025
14ed5df to
bb62755
Compare
ycdesu
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.