Skip to content

refactor: use the built-in max/min to simplify the code #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

refactor: use the built-in max/min to simplify the code #2016

merged 1 commit into from
May 8, 2025

Conversation

findnature
Copy link
Contributor

In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.

@findnature
refactor: use the built-in max/min to simplify the code
568c27e 
Signed-off-by: findnature <cricis@aliyun.com>
@findnature findnature requested a review from c9s as a code owner May 2, 2025 06:13
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 22.86%. Comparing base (9344784) to head (568c27e).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
pkg/optimizer/hpoptimizer.go 0.00% 2 Missing ⚠️
pkg/bbgo/exit_hh_ll_stop.go 0.00% 1 Missing ⚠️
pkg/exchange/bitget/stream.go 0.00% 1 Missing ⚠️
pkg/exchange/bybit/stream.go 0.00% 1 Missing ⚠️
pkg/migrations/mysql/migration_api.go 0.00% 1 Missing ⚠️
pkg/migrations/sqlite3/migration_api.go 0.00% 1 Missing ⚠️
pkg/strategy/drift/draw.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
- Coverage   22.86%   22.86%   -0.01%     
==========================================
  Files         673      673              
  Lines       52369    52381      +12     
==========================================
  Hits        11976    11976              
- Misses      39520    39533      +13     
+ Partials      873      872       -1
Files with missing lines Coverage Δ
pkg/types/kline.go 6.69% <100.00%> (+0.04%) ⬆️
pkg/util/string.go 100.00% <100.00%> (ø)
pkg/bbgo/exit_hh_ll_stop.go 0.00% <0.00%> (ø)
pkg/exchange/bitget/stream.go 20.72% <0.00%> (+0.12%) ⬆️
pkg/exchange/bybit/stream.go 22.82% <0.00%> (+0.14%) ⬆️
pkg/migrations/mysql/migration_api.go 56.00% <0.00%> (+2.15%) ⬆️
pkg/migrations/sqlite3/migration_api.go 56.00% <0.00%> (+2.15%) ⬆️
pkg/strategy/drift/draw.go 0.00% <0.00%> (ø)
pkg/optimizer/hpoptimizer.go 34.14% <0.00%> (+0.97%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fb73f...568c27e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@c9s c9s merged commit aa25c62 into c9s:main May 8, 2025
2 of 4 checks passed
@yinwenyu6 yinwenyu6 mentioned this pull request Aug 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@ycdesu ycdesu ycdesu approved these changes

@dboyliao dboyliao dboyliao approved these changes

+1 more reviewer

@narumiruna narumiruna narumiruna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@findnature @c9s @ycdesu @narumiruna @dboyliao