Skip to content

FIX:[coinbase] convert private symbols to local symbols when connecting user data stream #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

FIX:[coinbase] convert private symbols to local symbols when connecting user data stream #2014

merged 1 commit into from
Apr 30, 2025

Conversation

dboyliao
Copy link
Collaborator

No description provided.

ycdesu
ycdesu approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@ycdesu ycdesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to have a unit test for this case

@dboyliao
Copy link
Collaborator Author

Ok, I'll add one.

@dboyliao dboyliao force-pushed the dboy/fix-coinbase-private-symbols branch from 9e8f590 to aada978 Compare April 30, 2025 13:30
@dboyliao dboyliao enabled auto-merge April 30, 2025 13:34
@dboyliao dboyliao merged commit 354fd3b into main Apr 30, 2025
3 checks passed
@dboyliao dboyliao deleted the dboy/fix-coinbase-private-symbols branch April 30, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycdesu ycdesu ycdesu approved these changes

@gx578007 gx578007 gx578007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dboyliao @ycdesu @gx578007