FIX: [binance] apply new ws endpoint and use ed25519 authentication for spot trading #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37509fd to
37b7f95
Compare
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
4b6946e to
b2ab6a2
Compare
c9s
reviewed
Apr 28, 2025
30ed652 to
3329be6
Compare
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
c9s
reviewed
Apr 28, 2025
849fca6 to
65b2398
Compare
65b2398 to
858ec93
Compare
gx578007
reviewed
May 6, 2025
| if c.IsUsingEd25519Auth() { | ||
| // Ed25519 authentication | ||
| if len(c.PrivateKey) == 0 { | ||
| return nil, errEmptyPrivateKey |
There was a problem hiding this comment.
It should be impossible to happen while you have passed IsUsingEd25519Auth.
There was a problem hiding this comment.
But I think it is a good practice to apply defensive programming this way.
dboyliao
commented
May 6, 2025
| const FuturesWebSocketURL = "wss://fstream.binance.com" | ||
| const FuturesWebSocketTestURL = "wss://stream.binancefuture.com" | ||
| const TestNetFuturesWebSocketURL = "wss://stream.binancefuture.com" |
There was a problem hiding this comment.
This one does not look like testnet url.
Is it on purpose or a typo?
There was a problem hiding this comment.
It's just a rename from the above line<
dboyliao
commented
May 6, 2025
pkg/exchange/binance/exchange.go
Outdated
| usingEd25519 bool | ||
| } | ||
|
|
||
| func (e *ed25519authentication) getEd25519PrivateKey() ed25519.PrivateKey { |
There was a problem hiding this comment.
Looks like we are not using this method.
dboyliao
commented
May 6, 2025
pkg/exchange/binance/exchange.go
Outdated
| return e.privateKey | ||
| } | ||
|
|
||
| func (e *ed25519authentication) isUsingEd25519Auth() bool { |
…am. Backward compatible to HMAC authentication
…n RESTful API requests
- simplify exchange factory keys - add OptionKeyAPIPrivateKey - improve binance private key loading
38e987d to
c0df746
Compare
gx578007
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listenKeyis deprecated:https://developers.binance.com/docs/binance-spot-api-docs/CHANGELOG#user-data-streams