REFACTOR: [types] Add UUID to OrderQuery #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbearXD
reviewed
May 23, 2025
pkg/exchange/coinbase/exchange.go
Outdated
| cbOrder, err := req.Do(ctx) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to get order: %v", q.OrderID) | ||
| return nil, errors.Wrapf(err, "failed to get order: %v", q.UUID) |
There was a problem hiding this comment.
In line 383-387, we may query by q.OrderID. Should we add q.OrderID into the error message ?
There was a problem hiding this comment.
The order id is a hash value of q.UUID.
I was thinking knowing q.UUID is sufficient to know q.OrderID.
But I think you get a point.
If I choose to support q.OrderID as query condition as well, I should include it into the message as well.
I will include the entire q into the message with %+v.
c9s
reviewed
May 23, 2025
pkg/types/order.go
Outdated
| @@ -260,6 +260,7 @@ type OrderQuery struct { | |||
| Symbol string | |||
| OrderID string | |||
| ClientOrderID string | |||
| UUID string | |||
There was a problem hiding this comment.
call it OrderUUID? Align with the OrderID field
cdb6133 to
885bf04
Compare
c9s
approved these changes
May 26, 2025
kbearXD
approved these changes
May 26, 2025
885bf04 to
322a994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.