Skip to content

refactor: use slices.Contains to simplify code #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

refactor: use slices.Contains to simplify code #2041

merged 1 commit into from
May 29, 2025

Conversation

knowmost
Copy link
Contributor

use slices.Contains to simplify code

@knowmost
refactor: use slices.Contains to simplify code
6889513 
Signed-off-by: knowmost <knowmost@outlook.com>
@knowmost knowmost requested a review from c9s as a code owner May 21, 2025 03:02
@CLAassistant
Copy link

CLAassistant commented May 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 17.24%. Comparing base (de9d59e) to head (6889513).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
pkg/strategy/marketcap/strategy.go 0.00% 2 Missing ⚠️
pkg/types/serialmarketdatastore.go 0.00% 2 Missing ⚠️
pkg/types/currency/formatters.go 50.00% 1 Missing ⚠️
pkg/types/order.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
- Coverage   22.88%   17.24%   -5.65%     
==========================================
  Files         677      936     +259     
  Lines       52661    75881   +23220     
==========================================
+ Hits        12054    13086    +1032     
- Misses      39735    61862   +22127     
- Partials      872      933      +61
Files with missing lines Coverage Δ
pkg/pricesolver/simple.go 51.48% <100.00%> (-0.95%) ⬇️
pkg/util/apikey/loader.go 74.77% <100.00%> (ø)
pkg/types/currency/formatters.go 25.00% <50.00%> (ø)
pkg/types/order.go 1.49% <0.00%> (+0.02%) ⬆️
pkg/strategy/marketcap/strategy.go 0.00% <0.00%> (ø)
pkg/types/serialmarketdatastore.go 0.00% <0.00%> (ø)

... and 260 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3168eaa...6889513. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knowmost
Copy link
Contributor Author

Thanks for your review!

@c9s c9s merged commit 3179ece into c9s:main May 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@dboyliao dboyliao dboyliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knowmost @CLAassistant @c9s @dboyliao