FIX: [coinbase] refactoring and fix order-related streaming event handling #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d89e623 to
cb56fbf
Compare
2f1e02b to
318d4c5
Compare
c9s
approved these changes
Mar 10, 2025
d39c50c to
b5a8b58
Compare
c9s
reviewed
Mar 10, 2025
c9s
reviewed
Mar 10, 2025
pkg/exchange/coinbase/stream_test.go
Outdated
| accountsStr := os.Getenv("COINBASE_ACCOUNT_IDS") | ||
| accounts := strings.Split(accountsStr, ",") | ||
|
|
||
| c := make(chan bool) |
There was a problem hiding this comment.
you can use make(chan struct[}) and send c <- struct{}{}
c9s
reviewed
Mar 10, 2025
c9s
reviewed
Mar 10, 2025
…cker, match, full, level2, and balance messages
40dc4bc to
5a99df6
Compare
062dbce to
5b615ac
Compare
51b30a9 to
cf4f5ca
Compare
ycdesu
approved these changes
Mar 11, 2025
c9s
reviewed
Mar 11, 2025
pkg/exchange/coinbase/stream_test.go
Outdated
| triggered = true | ||
| assert.NotNil(t, m) | ||
| // t.Logf("get ticker message: %v", *m) | ||
| c <- *m |
There was a problem hiding this comment.
select {
case c <- m:
default:
}
select {
case c <- *m:
}
eb91fff to
52856b3
Compare
…channel type definitions
…working orders map
…to simplify the typing
…nhance test coverage and add race detection flags
…logging for stream events
450ccc2 to
0fc858a
Compare
…re stream closure is properly tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.SubmitOrderlogic, to simplify the streaming handlers logiclimit order with fundsstoporder on Coinbase Exchange) at long position .1., update order-related event handlers accordingly.