Skip to content

FIX: [exchange] fix bugs and revise Coinbase request structs #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

FIX: [exchange] fix bugs and revise Coinbase request structs #1909

merged 3 commits into from
Feb 26, 2025

Conversation

dboyliao
Copy link
Collaborator

@dboyliao dboyliao commented Feb 18, 2025 •
edited
Loading

  • add missing slug in the struct tags.
  • update data types for fields.
  • bug fix in pagination query function

@dboyliao dboyliao requested a review from c9s February 18, 2025 03:45
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Base automatically changed from dboy/coinbase to main February 25, 2025 06:23
@dboyliao dboyliao changed the title Add unit tests for CoinBase API FIX: [exchange] fix bugs and revise Coinbase request structs Feb 26, 2025
bailantaotao
bailantaotao reviewed Feb 26, 2025
View reviewed changes
.vscode/settings.json
@@ -0,0 +1,3 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's helpful to all the vscode users so I add it here.
It will help Go extension to load the local env file (just as instructed in the README) while running tests in vscode.
Should I ignore this?

pkg/exchange/coinbase/api/v1/get_candles_request.go
type GetCandlesResponse []RawCandle

func (rc *RawCandle) Candle() *Candle {
values := *rc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the rc is not nil and that the slice length is as expected. ( e.q. len == 6 ). Otherwise, the service will panic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dboyliao dboyliao mentioned this pull request Feb 26, 2025
Merged
@dboyliao dboyliao merged commit 02c2962 into main Feb 26, 2025
3 checks passed
@dboyliao dboyliao deleted the dboy/coinbase-test branch February 26, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bailantaotao bailantaotao bailantaotao approved these changes

@c9s c9s Awaiting requested review from c9s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dboyliao @CLAassistant @bailantaotao