Skip to content

fix: [okx] pass client order id #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix: [okx] pass client order id #1908

merged 1 commit into from
Feb 17, 2025

Conversation

ycdesu
Copy link
Collaborator

@ycdesu ycdesu commented Feb 17, 2025

In previous version, we always sent order id since the pointer will never be nil.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ycdesu ycdesu enabled auto-merge February 17, 2025 09:33
@ycdesu ycdesu merged commit b068579 into main Feb 17, 2025
2 of 3 checks passed
@ycdesu ycdesu deleted the fix/okx/send-client-order-id branch February 17, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bailantaotao bailantaotao bailantaotao approved these changes

@c9s c9s Awaiting requested review from c9s

@kbearXD kbearXD Awaiting requested review from kbearXD

@gx578007 gx578007 Awaiting requested review from gx578007

@narumiruna narumiruna Awaiting requested review from narumiruna

@dboyliao dboyliao Awaiting requested review from dboyliao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycdesu @CLAassistant @bailantaotao